-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pycrap to include soma and dul. #251
Open
tomsch420
wants to merge
30
commits into
cram2:dev
Choose a base branch
from
tomsch420:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjustments regarding imported Ontologies within the parsed Ontology
If a class starts with a digit it will be replaced with a written number: 6DPose -> SixDPose Added this fixes for Classes and Restrictions (At this time digit_to_string is not applied to the restriction bodies (ToDo)).
# Conflicts: # examples/cram_plan_tutorial.md # examples/location_designator.md # examples/motion_designator.md # src/pycram/datastructures/world.py # src/pycram/designator.py # src/pycram/designators/motion_designator.py # src/pycram/world_concepts/world_object.py # src/pycrap/agent.py # src/pycrap/objects.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pycrap got refactored to now include soma and dul. Furthermore a parser is added to parse any ontology that can be loaded with owlready2 into a python package that improves user experience and maintainability. When reviewing the PR, I recommend to only review the parser and not the actual content of the ontologies.